Overkill is my 2nd name.
-Hey overkill! They call me.
f-
--- ignore --
!! Procastination is evil !!
The driver is still small I know. But the problem of *looking for
something or finding the place for add some functionality* is getting
harder with every line....
!! evil evilness evilnita!!
I dont care if we leave everything in one file I'm just a little
afraid of the 'everithing is using everithing' patology. If at least I
can made the division in my head it will help me(and hopelly everyone
else) understand the use of the different parts.
-X related function should use some sepcific tables no one else is using.
-X related functions just touch one part of the usb not all type of registers
-ieee80211 interface should? never touch the usb directly or use some
obscure tables..
I think such a division helps answering quiestions like..
Where do I put this?
Where do I look for this functionality?
What's this related to?
(Right now all those are trivially answered with .. 'in the file`)
If we don't want to use the linker for this matters we can use some
convention and comments on the big file/s.?
DAaaaaaaaaaaahhhhh-
f-
2009/9/8 Christoph Hellwig <hch@???>:
> On Tue, Sep 01, 2009 at 10:45:21PM -0300, Felipe wrote:
>> Just as a starter for the file division discussion I propose from the
>> top of my head without really knowing the vt6656 internal functioning
>> this...
>
> Looking at the driver it seem absolutely overkill to me :) The driver
> is around 200 lines of non-header code right now. Keeping that in
> one file would be perfectly normal, and if we split it I really don't
> see much more division than the usb setup code and the ieee80211
> interface code, e.g. a small usb.c and a larger main.c. And of course
> the various tables need to move from vt6656_tables.h to a .c file
> e.g. initvals.c
>
> What might be more important to split is vt6656.h, I think it's
> generally useful to have one header for driver internal data structures
> and prototypes, and a second one for everything definining hardware
> interfaces.
> _______________________________________________
> Kernel-hackathon mailing list
> Kernel-hackathon@???
> https://mx.grulic.org.ar/mailman/listinfo/kernel-hackathon
>
(text/plain)